Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: Update endpoint stability information #1317

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

johngian
Copy link
Collaborator

@johngian johngian commented Mar 22, 2023

Related phabricator patch: https://phabricator.wikimedia.org/T328036

@johngian
Copy link
Collaborator Author

TODO: Link to the announcement

Copy link
Contributor

@thesocialdev thesocialdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the link.

Copy link

@dr0ptp4kt dr0ptp4kt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question/observation on Sunset: and header enrichment.

@@ -18,6 +18,7 @@ describe('Mobile Content Service', () => {
})
.then((res) => {
assert.deepEqual(res.status, 200);
assert.deepEqual(res.headers.deprecation, 'Sat, 01 Jul 2023 00:00:00 GMT');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this and the other be sunset instead of deprecation? I think @brightbyte was suggesting following the IETF draft in https://www.rfc-editor.org/rfc/rfc8594.html#section-3 (if deprecation is just a magical alias for sunset, please advise). No strong feeling here, just wanted to make sure I understood correctly!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right, updating the patch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sunset header is appropriate when we have set a data for decomissioning.
There is also a draft for a Deprecation header, which can be used earlier in the life cycle: https://greenbytes.de/tech/webdav/draft-ietf-httpapi-deprecation-header-latest.html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the spec Ι confused with the one you mentioned before @brightbyte

v1/mobileapps.js Show resolved Hide resolved
@brightbyte
Copy link
Contributor

I think something somewhere shoudl reference https://www.rfc-editor.org/rfc/rfc8594.html. Probably in a comment in the source code.

@johngian johngian merged commit ac011e3 into wikimedia:master Apr 6, 2023
@johngian johngian deleted the deprecate-mcs branch April 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants