-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: Update endpoint stability information #1317
Conversation
TODO: Link to the announcement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question/observation on Sunset:
and header enrichment.
test/features/mobileapps.js
Outdated
@@ -18,6 +18,7 @@ describe('Mobile Content Service', () => { | |||
}) | |||
.then((res) => { | |||
assert.deepEqual(res.status, 200); | |||
assert.deepEqual(res.headers.deprecation, 'Sat, 01 Jul 2023 00:00:00 GMT'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this and the other be sunset
instead of deprecation
? I think @brightbyte was suggesting following the IETF draft in https://www.rfc-editor.org/rfc/rfc8594.html#section-3 (if deprecation
is just a magical alias for sunset
, please advise). No strong feeling here, just wanted to make sure I understood correctly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, updating the patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sunset header is appropriate when we have set a data for decomissioning.
There is also a draft for a Deprecation header, which can be used earlier in the life cycle: https://greenbytes.de/tech/webdav/draft-ietf-httpapi-deprecation-header-latest.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the spec Ι confused with the one you mentioned before @brightbyte
I think something somewhere shoudl reference https://www.rfc-editor.org/rfc/rfc8594.html. Probably in a comment in the source code. |
Related phabricator patch: https://phabricator.wikimedia.org/T328036