Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the performance of parsoid regular expressions #1323

Merged
merged 2 commits into from
May 31, 2023
Merged

Optimize the performance of parsoid regular expressions #1323

merged 2 commits into from
May 31, 2023

Conversation

sbassett29
Copy link
Member

  • Sets length ranges for a few regular expressions that may
    result in polynomial-time performance in worst-case
    scenarios. A max range length of 128 seems reasonable
    based upon a limited analysis of available patterns.

Bug: T337274
@sbassett29
Optimize the performance of parsoid regular expressions
c65003a 
* Sets length ranges for a few regular expressions that may
  result in polynomial-time performance in worst-case
  scenarios.  A max range length of 128 seems reasonable
  based upon a limited analysis of available patterns.

Bug: T337274
@sbassett29
* Use 0 instead of 1 as min range for regular expression character cl…
c76ee7e 
…asses
subbuss
subbuss reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@subbuss subbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@johngian
Copy link
Collaborator

I think tests failures are transient from beta, master is also failing.
@sbassett29
Copy link
Member Author

I think tests failures are transient from beta, master is also failing.

I would assume so, given the fact that the tests are passing everywhere else. Are we still that concerned about supporting Node 10/sqlite for restbase?
@johngian
Copy link
Collaborator

I think its OK to merge. Either way though we need to fix the tests before deploying.
@johngian johngian merged commit a1edf24 into wikimedia:master May 31, 2023
7 of 8 checks passed
@johngian
Copy link
Collaborator

Tests should be OK now.
@sbassett29
Copy link
Member Author

Tests should be OK now.

Thanks! And thanks for merging this. This shouldn't require a manual deploy to get it into Wikimedia production, correct?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@sbassett29 @johngian @subbuss