Make parsoid transform follow disable_storage setting. #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdforrester
approved these changes
Nov 13, 2023
subbuss
reviewed
Nov 15, 2023
| let contentReq; | ||
|
|
||
| if (disabledStorage) { | ||
| contentReq = this._getPageBundleFromParsoid(hyper, req); |
There was a problem hiding this comment.
Can you confirm that this will fetch a stashed version from core? Otherwise, this could lead to dirty diffs? How are you testing this?
There was a problem hiding this comment.
Disabling storage also disabeld stashing, since RESTbase uses the storage mechanism to implement the stash. It doesn't use the Stash in MW.
But that should be a non-issue, since VE doesn't use this API anymore. As far as I know, nothing uses stashing in RESTbase. I have a PR up for removing it entirely.
|
I think that if this PR gets rebased to current master, CI will work (after fixes on master). |
If disable_storage is set, don't try to load the original HTML from cache for transform operations. Bug: T350219 Change-Id: I33c3baae4f0579121b89f6d913852d6c118ebd56
Change-Id: Id6f41779decdcd3bd2c7afdc7dbae143b7be5877
|
Other than a nit comment, lets squash and merge. |
Which comment? |
johngian
reviewed
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If disable_storage is set, don't try to load the original HTML from cache for transform operations.
Bug: T350219
Change-Id: I33c3baae4f0579121b89f6d913852d6c118ebd56