Edgewall Software
Modify ↓

Opened 2 years ago

Closed 9 months ago

#13480 closed defect (fixed)

Incorrect cache invalidation for BadIP and BadContent

Reported by: Ryan J Ollos Owned by: Dirk Stöcker
Priority: normal Milestone: plugin - spam-filter
Component: plugin/spamfilter Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In a multiprocess environment the cache is not refreshed for other processes. Jun has suggested:

We should use patterns method with @cache decorator and call del self.patterns when changing the wiki page.

The changes need to be implemented in:

  • IPRegexFilterStrategy: tracspamfilter/filters/ip_regex.py
  • RegexFilterStrategy: tracspamfilter/filters/regex.py

Attachments (2)

spam-filter-1.2-r17600.diff​ (10.7 KB ) - added by Jun Omae 18 months ago.
spam-filter-1.4-r17596.diff​ (10.7 KB ) - added by Jun Omae 18 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Maynard K., 2 years ago

I'll have a look at this one

by Jun Omae, 18 months ago

Attachment: spam-filter-1.2-r17600.diff​ added

by Jun Omae, 18 months ago

Attachment: spam-filter-1.4-r17596.diff​ added

comment:3 by Dirk Stöcker, 9 months ago

See comments in #13276. Im not really sure if it's worth the effort, but will have a look at the provided patches for recent 1.6 trunk version.

comment:4 by Dirk Stöcker, 9 months ago

Owner: changed from Ryan J Ollos to Dirk Stöcker

comment:5 by Dirk Stöcker, 9 months ago

Resolution: → fixed
Status: assigned → closed

In r17738.

Note: See TracTickets for help on using tickets.