Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(build): create error-y LHR for the deploy #9283

Merged
merged 11 commits into from
Jun 29, 2019
Merged

misc(build): create error-y LHR for the deploy #9283

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
efd41c9
misc(build): create error-y LHR for the deploy
paulirish Jun 25, 2019
10d1e03
add runwarning
paulirish Jun 26, 2019
f36c343
Update lighthouse-core/scripts/build-report-for-autodeployment.js
paulirish Jun 26, 2019
fbf2c9f
add in audit warnings, too
paulirish Jun 26, 2019
9245c3e
less obj.assign for stronger typing
paulirish Jun 26, 2019
3bc962f
some feedback
paulirish Jun 26, 2019
1e28415
cast the driver instead
paulirish Jun 27, 2019
68f6736
lint
paulirish Jun 27, 2019
de55da5
Merge branch 'master' into deployvariant-error
paulirish Jun 27, 2019
aa1b39b
drop other cast
paulirish Jun 27, 2019
76920df
feedback
paulirish Jun 28, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
less obj.assign for stronger typing
  • Loading branch information
@paulirish
paulirish committed Jun 26, 2019
commit 9245c3e06db72d7a19ed97c6d5c4112f665ccabe
30 changes: 14 additions & 16 deletions lighthouse-core/scripts/build-report-for-autodeployment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,23 +95,21 @@ async function generateErrorLHR() {
'Lighthouse was unable to automatically check the font-display value for the following URL: https://secure-ds.serving-sys.com/resources/PROD/html5/105657/20190307/1074580285/43862346571980472/fonts/IBMPlexSans-Bold-Latin1.woff.',
];
// perf/offscreen-images - set as passing but with a warning
Object.assign(errorLhr.audits['offscreen-images'], {
warnings: [
'Invalid image sizing information: https://cdn.cnn.com/cnn/.e1mo/img/4.0/vr/vr_new_asset.png',
],
errorMessage: undefined,
scoreDisplayMode: 'binary',
score: 1,
});
const offscreenImagesAudit = errorLhr.audits['offscreen-images'];
offscreenImagesAudit.warnings = [
'Invalid image sizing information: https://cdn.cnn.com/cnn/.e1mo/img/4.0/vr/vr_new_asset.png',
];
offscreenImagesAudit.errorMessage = undefined;
offscreenImagesAudit.scoreDisplayMode = 'binary';
offscreenImagesAudit.score = 1;
// pwa-apple-touch-icon - set as passing but with a warning
Object.assign(errorLhr.audits['apple-touch-icon'], {
warnings: [
'`apple-touch-icon-precomposed` is out of date; `apple-touch-icon` is preferred.',
],
errorMessage: undefined,
scoreDisplayMode: 'binary',
score: 1,
});
const appleTouchIconAudit = errorLhr.audits['apple-touch-icon'];
appleTouchIconAudit.warnings = [
'`apple-touch-icon-precomposed` is out of date; `apple-touch-icon` is preferred.',
];
appleTouchIconAudit.errorMessage = undefined;
appleTouchIconAudit.scoreDisplayMode = 'binary';
appleTouchIconAudit.score = 1;

return errorLhr;
}