-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(build): create error-y LHR for the deploy #9283
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
efd41c9
misc(build): create error-y LHR for the deploy
paulirish 10d1e03
add runwarning
paulirish f36c343
Update lighthouse-core/scripts/build-report-for-autodeployment.js
paulirish fbf2c9f
add in audit warnings, too
paulirish 9245c3e
less obj.assign for stronger typing
paulirish 3bc962f
some feedback
paulirish 1e28415
cast the driver instead
paulirish 68f6736
lint
paulirish de55da5
Merge branch 'master' into deployvariant-error
paulirish aa1b39b
drop other cast
paulirish 76920df
feedback
paulirish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update lighthouse-core/scripts/build-report-for-autodeployment.js
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
- Loading branch information
commit f36c343c39043a5483e637da5e9be08ba172d172
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One downside here is that ts-ignore is going to make this invisible to any breaking changes made to initializeBaseArtifacts, and since it's an internal method that could pretty easily happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about throwing a ts-ignore/cast on the driver object instead?