Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Alpine 3.20 #441

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Conversation

williamdes
Copy link
Contributor

Not sure why but my simple test is broken

#10 2.970   "files": [
#10 2.970 
#10 2.970   ],
#10 2.970   "percent_covered": "0.00",
#10 2.970   "covered_lines": 0,
#10 2.970   "total_lines": 0,
#10 2.970   "percent_low": 25,
#10 2.970   "percent_high": 75,
#10 2.970   "command": "test-executable.sh",
#10 2.970   "date": "2024-07-07 17:57:41"

No percent and no file reported

@williamdes williamdes force-pushed the multi-arch branch 2 times, most recently from be764b2 to a62f9e6 Compare July 7, 2024 18:48
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@williamdes williamdes marked this pull request as ready for review July 8, 2024 15:50
@williamdes
Copy link
Contributor Author

Docker is building at: https://github.com/williamdes/kcov/actions/runs/9842731065/job/27172308187
Should be ready to merge

@williamdes
Copy link
Contributor Author

By the way libcurl seems to have some deprecation notices: https://github.com/williamdes/kcov/actions/runs/9842731065/job/27172308187#step:6:1266

@williamdes
Copy link
Contributor Author

About the example binary, if you can add it after the merge to the existing CI scripts I can copy the login into the Dockerfile

@SimonKagstrom SimonKagstrom merged commit ce4b38b into SimonKagstrom:master Jul 8, 2024
9 checks passed
@williamdes williamdes deleted the multi-arch branch July 8, 2024 17:13
@SimonKagstrom
Copy link
Owner

Thanks for the PR, great work!

Don't worry about the binary. I suspect it won't be possible to run anyway in the docker image, at least on non-x86 images, so I think the current variant is good enough. It's tested in the regular CI runs anyhow.

@williamdes
Copy link
Contributor Author

Thank you for the very active and nice collaboration !
I updated https://github.com/sudo-bot/action-kcov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants