Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux correct ptrace calls #443

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

SimonKagstrom
Copy link
Owner

No description provided.

@SimonKagstrom
Copy link
Owner Author

@williamdes I sort of stole this, but the cast was really only needed for PowerPC, so it has been removed on all other architectures with this PR.

Unrelated to that, I added DOCKER_USERNAME+DOCKER_PASSWORD to the environment secrets now. Is there anything else to do, or will that work by magic after that?

@williamdes
Copy link
Contributor

Unrelated to that, I added DOCKER_USERNAME+DOCKER_PASSWORD to the environment secrets now. Is there anything else to do, or will that work by magic after that?

Nothing more, you should not see the secrets anymore in the normal secret list now.
Did you use a token and not a password ?

I hesitated to use vars.DOCKER_USERNAME but it would have broken the setup.
Feel free to move the username to a variable as it is not sensitive and can help with debug sometimes.

@SimonKagstrom SimonKagstrom merged commit 2d7b488 into master Jul 8, 2024
18 checks passed
@williamdes williamdes mentioned this pull request Jul 8, 2024
@SimonKagstrom
Copy link
Owner Author

Didn't move to a token yet, need to readup a bit more first!

@williamdes
Copy link
Contributor

Didn't move to a token yet, need to readup a bit more first!

Sure
https://hub.docker.com/settings/security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants