Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2351 bbm.schema.json $id path is updated incorrectly #2362

Merged

Conversation

Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 7babb7e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mearman Mearman requested a review from dglazkov June 28, 2024 19:26
@Mearman Mearman self-assigned this Jun 28, 2024
Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some build breakage.

Also 🙏🏻 smaller patches, smaller changes. I would rather review a bunch of five-liners than these.

Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dglazkov dglazkov enabled auto-merge (squash) June 28, 2024 20:46
auto-merge was automatically disabled June 28, 2024 21:00

Head branch was pushed to by a user without write access

@Mearman
Copy link
Collaborator Author

Mearman commented Jun 28, 2024

Also 🙏🏻 smaller patches, smaller changes. I would rather review a bunch of five-liners than these.

@dglazkov Sorry, was aiming for it, but ended up being interconnected changes.

@Mearman Mearman force-pushed the 2351-bbmschemajson-id-path-is-updated-in branch from dc67705 to 61078e1 Compare June 29, 2024 09:28
@paullewis
Copy link
Contributor

Would you mind adding the license header to the files? Otherwise looks good to go!

@paullewis paullewis merged commit bc8dcdd into breadboard-ai:main Jul 1, 2024
2 checks passed
paullewis pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants