-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2351 bbm.schema.json $id path is updated incorrectly #2362
2351 bbm.schema.json $id path is updated incorrectly #2362
Conversation
Mearman
commented
Jun 28, 2024
- resolves bbm.schema.json $id path is updated incorrectly #2351
…json-id-path-is-updated-in
🦋 Changeset detectedLatest commit: 7babb7e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some build breakage.
Also 🙏🏻 smaller patches, smaller changes. I would rather review a bunch of five-liners than these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Head branch was pushed to by a user without write access
@dglazkov Sorry, was aiming for it, but ended up being interconnected changes. |
…json-id-path-is-updated-in
dc67705
to
61078e1
Compare
Would you mind adding the license header to the files? Otherwise looks good to go! |