Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest with GraphDescriptor ref #2370

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Update manifest with GraphDescriptor ref #2370

merged 7 commits into from
Jul 1, 2024

Conversation

Mearman
Copy link
Collaborator

@Mearman Mearman commented Jun 29, 2024

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4fc20a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR
@Mearman Mearman self-assigned this Jun 29, 2024
@Mearman Mearman requested a review from dglazkov June 29, 2024 11:48
@Mearman Mearman changed the title Update manifest with graphdesciptor ref Jun 29, 2024
@Mearman Mearman force-pushed the update-manifest-with-graphdesciptor-ref branch from f22f613 to 68fdaf3 Compare July 1, 2024 10:22
paullewis
paullewis requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@paullewis paullewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Nit, though: please can you remove any commented lines?
@Mearman Mearman force-pushed the update-manifest-with-graphdesciptor-ref branch from 68fdaf3 to da407b7 Compare July 1, 2024 12:36
@Mearman Mearman requested a review from paullewis July 1, 2024 13:01
@paullewis paullewis merged commit 748e3c5 into breadboard-ai:main Jul 1, 2024
2 checks passed
paullewis added a commit that referenced this pull request Jul 1, 2024
@paullewis
Revert "Update manifest with GraphDescriptor ref (#2370)"
36560e8 
This reverts commit 748e3c5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Mearman @paullewis