Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping 'Configure Map' step breaks context configuration #10197

Closed
1 task done
allyoucanmap opened this issue Apr 12, 2024 · 1 comment · Fixed by #10207 or #10210
Closed
1 task done

Skipping 'Configure Map' step breaks context configuration #10197

allyoucanmap opened this issue Apr 12, 2024 · 1 comment · Fixed by #10207 or #10210
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug Internal investigation
Milestone
2024.01.00

Comments

@allyoucanmap
Copy link
Contributor

Description

The context configuration will break if a user skip the configure map step while editing it

skip-step.mp4

How to reproduce

  • create a new context and save
  • edit the saved context
  • click on Configure Plugins and skip Configure Map
  • ad a new plugin (eg 3D)
  • click on next and save
  • open the context map viewer

Expected Result

The context map viewer is visible with the correct configuration

Current Result

The context map viewer is not visible with the infiinite loading spinner and an error in console

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@allyoucanmap allyoucanmap added this to the 2024.01.00 milestone Apr 12, 2024
@allyoucanmap allyoucanmap changed the title Skip configure map step breaks context configuration Apr 12, 2024
@tdipisa tdipisa added Internal BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch investigation labels Apr 15, 2024
@tdipisa
Copy link
Member

tdipisa commented Apr 15, 2024

@mahmoudadel54
This problems affects also QA. We have to include a fix for this regression for 2024.01.00
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 15, 2024
@mahmoudadel54
geosolutions-it#10197: fix Skipping 'Configure Map' step breaks conte…
b1b2c0b 
…xt configuration

- fix the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab
- write a unit test for this change
@mahmoudadel54 mahmoudadel54 mentioned this issue Apr 15, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Apr 15, 2024 that will close this issue
#10197: fix Skipping 'Configure Map' step breaks context configuration #10207
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 16, 2024
@mahmoudadel54
geosolutions-it#10197: fix Skipping 'Configure Map' step breaks conte…
fa22752 
…xt configuration

Description:
- resolve the review comments
dsuren1 pushed a commit that referenced this issue Apr 16, 2024
@mahmoudadel54
#10197: fix Skipping 'Configure Map' step breaks context configuration (
331e9fd 
#10207)

* #10197: fix Skipping 'Configure Map' step breaks context configuration
- fix the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab
- write a unit test for this change

* #10197: fix Skipping 'Configure Map' step breaks context configuration
Description:
- resolve the review comments
@ElenaGallo ElenaGallo self-assigned this Apr 16, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 16, 2024
@mahmoudadel54
geosolutions-it#10197: fix Skipping 'Configure Map' step breaks conte…
4dbd6b0 
…xt configuration (geosolutions-it#10207)

* geosolutions-it#10197: fix Skipping 'Configure Map' step breaks context configuration
- fix the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab
- write a unit test for this change

* geosolutions-it#10197: fix Skipping 'Configure Map' step breaks context configuration
Description:
- resolve the review comments
@mahmoudadel54 mahmoudadel54 mentioned this issue Apr 16, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Apr 16, 2024 that will close this issue
[Backport 2024.01.xx] #10197: fix Skipping 'Configure Map' step breaks context configuration (#10207) #10210
Merged
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 16, 2024
tdipisa pushed a commit that referenced this issue Apr 16, 2024
@mahmoudadel54
#10197: fix Skipping 'Configure Map' step breaks context configuration (
183a229 
#10207) (#10210)

* #10197: fix Skipping 'Configure Map' step breaks context configuration
- fix the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab
- write a unit test for this change

* #10197: fix Skipping 'Configure Map' step breaks context configuration
Description:
- resolve the review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted bug Internal investigation
4 participants
@tdipisa @allyoucanmap @ElenaGallo @mahmoudadel54