#10197: fix Skipping 'Configure Map' step breaks context configuration #10207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt configuration - fix the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab - write a unit test for this change
mahmoudadel54
added
bug
investigation
Internal
BackportNeeded
1 task
dsuren1
requested changes
Apr 16, 2024
There was a problem hiding this comment.
@mahmoudadel54 Fix works. However, can you please look into the suggestions below, thanks
…xt configuration Description: - resolve the review comments
dsuren1
requested changes
Apr 16, 2024
dsuren1
approved these changes
Apr 16, 2024
|
@ElenaGallo Kindly test it in DEV and let us know if it can be backported. Thanks! |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Apr 16, 2024
…xt configuration (geosolutions-it#10207) * geosolutions-it#10197: fix Skipping 'Configure Map' step breaks context configuration - fix the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab - write a unit test for this change * geosolutions-it#10197: fix Skipping 'Configure Map' step breaks context configuration Description: - resolve the review comments
|
ElenaGallo
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Apr 16, 2024
#10207) (#10210) * #10197: fix Skipping 'Configure Map' step breaks context configuration - fix the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab - write a unit test for this change * #10197: fix Skipping 'Configure Map' step breaks context configuration Description: - resolve the review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR: fixing the issue of beak context due to missing map config in case of edit an existing context by skip map configure tab
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10197
What is the current behavior?
#10197
What is the new behavior?
Editing an existing context by skip map configure tab is working without break context
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information