Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning of data dirs #8465

Closed
1 of 6 tasks
MV88 opened this issue Aug 8, 2022 · 8 comments
Closed
1 of 6 tasks

Versioning of data dirs #8465

MV88 opened this issue Aug 8, 2022 · 8 comments

Comments

@MV88
Copy link
Contributor

MV88 commented Aug 8, 2022

Description

Add versioning of data dirs

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes infrastructure change
  • Other... Please describe:

Other useful information

MS data dir repo here: https://github.com/geosolutions-it/mapstore-datadir

@tdipisa
Copy link
Member

tdipisa commented Aug 8, 2022

@randomorder let's decide together the best approach. Thank you @MV88.

@tdipisa
Copy link
Member

tdipisa commented Aug 9, 2022

As agreed also with @randomorder three branches have been created in mapstore-datadir repo, one for each MS instance we have to maintain: DEV, QA and STABLE.

@ibrahimcengizgeo has already versioned the current state while @MV88 will update each branch next days according to what scheduled for #7165.

Three additional J. Jobs or a GHA will be created to fetch updates from each branch of mapstore-datadir and so update the data dir of each instance (eg. one datadir update job for each MS instance). A separate issue (#1046) has been created for the implementation of these jobs/gha.

@tdipisa
Copy link
Member

tdipisa commented Aug 9, 2022

@MV88 jenkins jobs are already in place and the update of data dirs is triggered automatically after few minutes when we commit/merge updates. I've asked @ibrahimcengizgeo to put a brief documentation about the three jobs in the repo readme.

@MV88
Copy link
Contributor Author

MV88 commented Aug 9, 2022

@tdipisa thanks, i like the fact there is no manual operation involved other than pushing changes to the datadir repo

@ibrahimcengizgeo
Copy link
Contributor

@tdipisa, @MV88
it seems this task was assigned to me. if it's not related to me I will unassign it,
I guess only https://github.com/geosolutions-it/DevOps/issues/1046 was on me.

@MV88
Copy link
Contributor Author

MV88 commented Aug 10, 2022

yes, you can unassign now

@tdipisa
Copy link
Member

tdipisa commented Aug 30, 2022

@offtherailz
Copy link
Member

There are no functional changes in this PR. The refactor involves the geoserver integrations. So please test them on DEV and QA.
I tested on myself the integration is working.

The only thing left is to merge this during release. https://github.com/geosolutions-it/mapstore-datadir/pull/4
Already noted in #8660

So I'm going to close and accept this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment