#7165 clean up configs for externalized datadir and documentation update #8522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV88
added
enhancement
Priority: High
Internal
BackportNeeded
12 tasks
offtherailz
requested changes
Sep 28, 2022
There was a problem hiding this comment.
During the release I checked your canges to the release procedure to see these what could conflict with an update due to the things to update now and I notices some parts to comment.
I write this (incomplete) review to avoid to loose these comments. We can check it at the proper moment.
| ## [${newReleaseNumber}](https://github.com/geosolutions-it/MapStore2/tree/v${newReleaseNumber}) (${today}) | ||
|
|
||
| - **[Full Changelog](https://github.com/geosolutions-it/MapStore2/compare/v${oldReleaseNumber}...v${newReleaseNumber})** | ||
|
|
There was a problem hiding this comment.
need to add new-features label tag too,
Something like :
- **[Implemented new features](https://github.com/geosolutions-it/MapStore2/issues?q=is%3Aissue+milestone%3A${newVersionNumber}+is%3Aclosed+label%3A%22New+Feature%22)**
|
|
||
| - **[Fixed bugs](https://github.com/geosolutions-it/MapStore2/issues?q=is%3Aissue+milestone%3A%22${newReleaseNumber}%22+is%3Aclosed+label%3Abug)** | ||
|
|
||
| - **[Closed issues](https://github.com/geosolutions-it/MapStore2/issues?q=is%3Aissue+milestone%3A%22${newReleaseNumber}%22+is%3Aclosed)** |
There was a problem hiding this comment.
Need to add the related mapstore extension link, something like
- **[Related MapStrore extensions release v${newReleaseNumber}](https://github.com/geosolutions-it/MapStoreExtension/releases/tag/v${newReleaseNumber)**
Comment on lines
+329
to
+330
| '/geofence': { | ||
| target: `${baseUrl}` |
There was a problem hiding this comment.
geofence doesn't exist locally, I should remove it.
Comment on lines
+303
to
+324
| "start": "npm run frontend:dev", | ||
| "start:both": "concurrently \"npm:frontend:dev\" \"npm:backend:dev\"", | ||
|
|
||
| "frontend:dev": "webpack serve --progress --color --port 8081 --hot --inline --config build/webpack.config.js --content-base web/client", | ||
| "frontend:dev-prod": "webpack serve --progress --color --port 8081 --hot --inline --config build/prod-webpack.config.js --content-base web/client", | ||
| "frontend:build": "npm run clean && mkdirp ./web/client/dist && webpack build --progress --color --config build/prod-webpack.config.js", | ||
| "compile": "npm run frontend:build", | ||
|
|
||
| "backend:build": "mvn clean install -Pprinting", | ||
| "backend:dev": "npm run backend:build && mvn cargo:run -f ./product/pom.xml", | ||
|
|
||
| "pretest": "npm run doc:clean && npm run lint", | ||
| "test": "karma start ./build/karma.conf.single-run.js --color", | ||
| "test:watch": "karma start ./build/karma.conf.continuous-test.js --color", | ||
| "continuoustest": "npm run test:watch", | ||
|
|
||
| "doc": "docma -c build/docma-config.json --dest web/docs", | ||
| "build-doc": "mkdocs build", | ||
| "serve-doc": "mkdocs serve", | ||
| "cleandoc": "rimraf web/docs && rimraf web/client/mapstore/docs", | ||
| "doctest": "docma -c build/docma-config.json --dest web/client/mapstore/docs && echo documentation is accessible from the mapstore/docs path when running npm start", | ||
| "i18n": "node utility/translations/findMissingTranslations.js", | ||
| "doc:clean": "rimraf web/docs && rimraf web/client/mapstore/docs", | ||
| "doc:test": "docma -c build/docma-config.json --dest web/client/mapstore/docs && echo documentation is accessible from the mapstore/docs path when running npm start", | ||
| "doc-build": "mkdocs build", | ||
| "doc-serve": "mkdocs serve", | ||
| "cleandoc": "npm run doc:clean", |
There was a problem hiding this comment.
npm startshould run both front-end and back-end (running front end alone is not immediate, you have to change webpack configuration, so it is better to use the simple command for the easer way). Instead of start:both- I should shorten frontend and backend into
fe:andbe:. So we can writefe:start,fe:build - I should avoid
devand instead i should usestart.devis harder to understand, you are starting the front-end and back-end (only the front-end in fact is in dev mode). - Accordingly to the semantic used, we should use also
doc:buildmdoc:serveanddoc:clean, instead ofdoc-build,doc-serveandcleandoc.
offtherailz
reviewed
Sep 28, 2022
offtherailz
reviewed
Sep 28, 2022
12 tasks
|
closing in favor of #8645 |
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To merge after this one: #8511
This pr introduces:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#7165 externalize datadir
What is the new behavior?
Now authentication rules are not part of localconfig
scripts have changed
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information