-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable PDF generation #9383
Comments
@offtherailz @tdipisa My notes:
** mkdocs-pdf-export-plugin plugin build time with ENABLE_PDF_EXPORT=1 |
Dear @mahmoudadel54 Thank you so much for this. This seems really good. Some feedback below. @offtherailz will follow as soon as possible. What is this? I think it should be fixed.
I would like to:
Yes, also in the previous version was like that. Anyway, let me know if we can do something to improve for this and if you need time for this let me also know how much. |
Hi @tdipisa
You can check this link: https://mapstoreforkwithpdfplugin.readthedocs.io/en/issue_9383/ |
@mahmoudadel54 a couple of things more
please put it on the right with also a PDF icon on the left
The second line should be the copyright. Please use the same you find in footer for now |
So I suggest to drop this requirment, also because is not trivial to add it, and not so necessary. @tdipisa can we avoid this requirement? |
Description: - Remove mkdocs-pdf-export-plugin and use mkdocs-with-pdf plugin instead - Create pdf_event_hook.py to render the export pdf icon into the docs - Append the export pdf icon into the navbar on the right side
Description: - Remove mkdocs-pdf-export-plugin and use mkdocs-with-pdf plugin instead - Create pdf_event_hook.py to render the export pdf icon into the docs - Customize the location of the export pdf icon into the navbar on the right side
Description: - edit formatting of the mkdocs.yml file
Description: - replace svg icon with image for the export pdf icon in pdf_event_hook.py file
@ElenaGallo I understood you have enabled this for but that's not the usual latest endpoint used which is /latest indeed. Can you please fix? |
@ElenaGallo can you please completely remove the master one please? |
@tdipisa done |
Last version available at: https://docs.mapstore.geosolutionsgroup.com/en/latest/ |
Description
Because of changes reported in #9369 , we needed to temorary disable PDF generation. With #9373 we have a version of the PDF that works (videos are not included).
Anyway:
We have an alternative using
with-pdf
lib:It's configuration have to be added in mkdocs.yml file, with the following output.
We have to evaluate
ENABLE_PDF_EXPORT=1
, now is set to0
due to the bad quality of the PDF generated)The text was updated successfully, but these errors were encountered: