#9383: Re-enable PDF generation #9973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Remove mkdocs-pdf-export-plugin and use mkdocs-with-pdf plugin instead - Create pdf_event_hook.py to render the export pdf icon into the docs - Customize the location of the export pdf icon into the navbar on the right side
Description: - edit formatting of the mkdocs.yml file
Description: - replace svg icon with image for the export pdf icon in pdf_event_hook.py file
tdipisa
requested review from
allyoucanmap
and removed request for
offtherailz
allyoucanmap
approved these changes
Feb 23, 2024
|
@ElenaGallo please test this fix on dev, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I replaced mkdocs-pdf-export plugin with mkdocs-with-pdf to enable PDF generation with a better layout and in a less build time.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9383
What is the current behavior?
#9383
What is the new behavior?
Enabling PDF generation with a better layout and in a less build time.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information