Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thematic tool integration in Visual Style Editor #9916

Closed
1 of 6 tasks
mahmoudadel54 opened this issue Jan 25, 2024 · 0 comments · Fixed by #9971
Closed
1 of 6 tasks

Thematic tool integration in Visual Style Editor #9916

mahmoudadel54 opened this issue Jan 25, 2024 · 0 comments · Fixed by #9971

Comments

@mahmoudadel54
Copy link
Collaborator

Description

As per issue title the aim of the issue if to integrate specific features available in the Stat Query Engine tool into the Visual stile editor in order to dismiss the first one in favor of the second.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

MS issue to be created for 2024.01.00

Note: Thematic layer should be removed anyway for security reason because is using SLD parameter in the GetMap.

  • Integrate the view parameters configuration UI component in the visual style editor to enhance the classification result, only the params will be supported and fields will be removed. Attributes with the same name of view parameters should be highlighted so the user could understand the relation with view parameters (see screenshots)
  • Enhance the workflow of the vector classification to support only the parameters for view params (eg: msViewParametes, name to review)
  • Complete removal of the ThematicLayer plugin from MS

Image

Most of the classification functionalities are already included in the visual style editor; the only missing part is the possibility to include inside the classification additional view parameters of a layer using the thematic property. The thematic property provides an array of fields where each one represents a select input, once a user selects one of this input the associated view parameter is included in the classify.json request to the SLD service. We could have a global setting button inline with the undo/redo because this configuration has an effect on all classification rules symbolizers.

@mahmoudadel54 mahmoudadel54 added this to the 2024.01.00 milestone Jan 25, 2024
@mahmoudadel54 mahmoudadel54 self-assigned this Jan 25, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Feb 12, 2024
…Style Editor

Description:
- Handle integration thematic layer logic into visual style editor by adding cog icon into classification style rule to enable user to enter custom params
- Integrate the view parameters configuration UI component in the visual style editor and showing the entered custom params above the color palette.
- Write unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Feb 12, 2024
…Style Editor

Description:
- Edit in translations + adding missing a translate
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Feb 12, 2024
…Style Editor

Description:
- Edit unit test file for failure FE test
@ElenaGallo ElenaGallo self-assigned this Mar 4, 2024
@tdipisa tdipisa changed the title Stat Query Engine integration in Visual Style Editor May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment