Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9916: handle Stat Query Engine integration in Visual Style Editor #9971

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

mahmoudadel54
Copy link
Collaborator

Description

In this PR, these following points are handled:

  • Integration thematic layer logic into visual style editor by adding cog icon into classification style rule to enable user to enter custom parameters
  • Integrate the view parameters configuration UI component in the visual style editor and showing the entered custom parameters above the color palette.
  • When a user selects one of this input custom parameters the associated view parameter is included in the classify.json request to the SLD service.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?
#9916

What is the new behavior?
Enable adding custom parameters into classification style rule for vector classification like using the thematic property.
The thematic property provides an array of fields where each one represents a select input, once a user selects one of this input the associated view parameter is included in the classify.json request to the SLD service.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Removing the thematic layer is not implemented yet until finishing the complete review.

…Style Editor

Description:
- Handle integration thematic layer logic into visual style editor by adding cog icon into classification style rule to enable user to enter custom params
- Integrate the view parameters configuration UI component in the visual style editor and showing the entered custom params above the color palette.
- Write unit tests
mahmoudadel54 and others added 4 commits February 12, 2024 14:18
…Style Editor

Description:
- Edit in translations + adding missing a translate
…Style Editor

Description:
- Edit unit test file for failure FE test
@allyoucanmap allyoucanmap marked this pull request as ready for review February 27, 2024 15:39
@allyoucanmap allyoucanmap changed the title #9916: handle Stat Query Engine integration in Visual Style Editor Feb 27, 2024
@allyoucanmap allyoucanmap merged commit d3d5fbc into geosolutions-it:master Feb 29, 2024
6 checks passed
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test this improvement on dev, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment