Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapillary viewer for custom 360 Imagery #9978

Closed
mahmoudadel54 opened this issue Feb 16, 2024 · 0 comments · Fixed by #10027
Closed

Mapillary viewer for custom 360 Imagery #9978

mahmoudadel54 opened this issue Feb 16, 2024 · 0 comments · Fixed by #10027
Assignees
@allyoucanmap @ElenaGallo @mahmoudadel54
Labels
3D All issues related to the 3D rendering in CesiumJs 360 Imagery Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT New Feature used for new functionalities
Milestone
2024.02.00

Comments

@mahmoudadel54
Copy link
Collaborator

mahmoudadel54 commented Feb 16, 2024 •
edited by tdipisa
Loading

Description

The aim of this issue is to enhance the current Street View plugin adding Mapillary as an additional viewer for 360 imagery custom provider.

Acceptance criteria

  • The purpose is visualization only inside MapStore using the Mapillary viewer
  • Integration in MapStore extending the configuration of the Street View plugin. This includes:
    • Review o/refactor of design and interactions with the plugin components
    • Extend localConfig.json configuration of the plugin to support multiple provider: Google Street View and Mapillary
    • Generalize action to support multiple providers and components
    • Review map icon
  • [both 2D/3D] Add mapillary.js as an alternative viewer configurable to access custom data provider, which means serving a set of aggregated pre-processed runs of 360 images (without using the Mapillary default provider)
    • New components to visualize the mapillary.js viewer
    • Workflow to apply correct layers on map. Data conversion has been focused on small tracks using GeoJSON files, in case of large datasets we will need a different approach.
    • Add map support to control layers

Other useful information
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.00 milestone Feb 16, 2024
@mahmoudadel54 mahmoudadel54 self-assigned this Feb 16, 2024
@tdipisa tdipisa modified the milestones: 2024.01.00, 2024.02.00 Feb 27, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Mar 6, 2024
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
8a54503 
Description:
- adding the mapillary viewer for 360 photo support beside Google amd cyclemedia
- handle view custom 360 photos into mapillary viewer using GeoJSONDataProvider
- handle view the custom images in 2d and 3d modes
- install mapillary-js npm package
- edit VectorLayer to enable add layer features via geojson url in 2d + 3d views
- adding unit tests for mapillary
@mahmoudadel54 mahmoudadel54 mentioned this issue Mar 6, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Mar 6, 2024 that will close this issue
#9978: Add 360 photo support with Mapillary #10027
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Mar 6, 2024
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
147352f 
Description:
- edit the test img for mapillary
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Mar 6, 2024
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
cbabe15 
Description:
- fix issues in unit tests
- edit in test files of mapillary
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Mar 7, 2024
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
d032ce5 
Description:
- edit in mapillary unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Mar 15, 2024
@mahmoudadel54
geosolutions-it#9978: Resolve review comments on [360 photo support w…
aa950c6 
…ith Mapillary]

Description:
-  remove all the changes in VectorLayer and move zoomTo layer in streetView epics
- add a notification if the service is not available for mapillary custom data layer
- replace legacy way of style with geostyler for marker streetview
- edit the streetview in monitorState to be more specific
- edit unit cases based on changes
@tdipisa tdipisa changed the title 360 Photos Support Apr 5, 2024
@tdipisa tdipisa changed the title Mapillary support for 360 Photos Apr 5, 2024
@tdipisa tdipisa mentioned this issue Apr 5, 2024
Open
6 tasks
@tdipisa tdipisa removed the new label Apr 5, 2024
tdipisa pushed a commit that referenced this issue Apr 16, 2024
@mahmoudadel54 @allyoucanmap
#9978: Add 360 photo support with Mapillary (#10027)
0ec0d92 
* #9978: Add 360 photo support with Mapillary
Description:
- adding the mapillary viewer for 360 photo support beside Google amd cyclemedia
- handle view custom 360 photos into mapillary viewer using GeoJSONDataProvider
- handle view the custom images in 2d and 3d modes
- install mapillary-js npm package
- edit VectorLayer to enable add layer features via geojson url in 2d + 3d views
- adding unit tests for mapillary

* #9978: Add 360 photo support with Mapillary
Description:
- edit the test img for mapillary

* #9978: Add 360 photo support with Mapillary
Description:
- fix issues in unit tests
- edit in test files of mapillary

* #9978: Add 360 photo support with Mapillary
Description:
- edit in mapillary unit tests

* #9978: Resolve review comments on [360 photo support with Mapillary]
Description:
-  remove all the changes in VectorLayer and move zoomTo layer in streetView epics
- add a notification if the service is not available for mapillary custom data layer
- replace legacy way of style with geostyler for marker streetview
- edit the streetview in monitorState to be more specific
- edit unit cases based on changes

* review marker rotation and 3d support

* revert changes in cesium vector layer

* revert changes in ol vector layer

* revert changes in url utils

* add tests

* fix jsdoc

* remove zoom to action and added clamp to ground option

* fix geojson data provider

---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
@ElenaGallo ElenaGallo self-assigned this Apr 16, 2024
@ElenaGallo ElenaGallo mentioned this issue Apr 16, 2024
Open
2 tasks
@tdipisa tdipisa added the 3D All issues related to the 3D rendering in CesiumJs label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs 360 Imagery Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT New Feature used for new functionalities
4 participants
@tdipisa @allyoucanmap @ElenaGallo @mahmoudadel54