Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9978: Add 360 photo support with Mapillary #10027

Merged
merged 15 commits into from
Apr 16, 2024
Merged

#9978: Add 360 photo support with Mapillary #10027

merged 15 commits into from
Apr 16, 2024

Conversation

mahmoudadel54
Copy link
Collaborator

@mahmoudadel54 mahmoudadel54 commented Mar 6, 2024 •
edited
Loading

Description

  • adding the mapillary viewer for 360 photo support beside Google amd cyclomedia
  • handle view custom 360 photos into mapillary viewer using GeoJSONDataProvider
  • handle view the custom images in 2d and 3d modes
  • install mapillary-js npm package
  • edit VectorLayer to enable add layer features via geojson url in 2d + 3d views
  • adding unit tests for mapillary

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9978

What is the current behavior?
#9978

What is the new behavior?
360 Photo support with mapillary viewer is added. It currently is to view only the custom 360 images provided by client not the default mapillary images. User can add the ApiURL parameter into cfg of the streetView plugin in the created context.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

360 Photo support for mapillary is added just for the custom 360 images that can be provided by the client not the default mapillary provider.

  • Adding the default mapillary provider is applicable for 2D by adding vector tile support into openLayers [it is not supported in MS] and it needs investigation to handle it in 3D as there is no straight forward support for vector tile layers into Cesium.
  • I have added a custom logic to enable vector layer to get url of a geojson file to load its features into the layer for openLayers and Cesium as well.
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
8a54503 
Description:
- adding the mapillary viewer for 360 photo support beside Google amd cyclemedia
- handle view custom 360 photos into mapillary viewer using GeoJSONDataProvider
- handle view the custom images in 2d and 3d modes
- install mapillary-js npm package
- edit VectorLayer to enable add layer features via geojson url in 2d + 3d views
- adding unit tests for mapillary
@mahmoudadel54 mahmoudadel54 self-assigned this Mar 6, 2024
@mahmoudadel54 mahmoudadel54 added this to the 2024.02.00 milestone Mar 6, 2024
@mahmoudadel54 mahmoudadel54 linked an issue Mar 6, 2024 that may be closed by this pull request
Mapillary viewer for custom 360 Imagery #9978
Closed
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
147352f 
Description:
- edit the test img for mapillary
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
cbabe15 
Description:
- fix issues in unit tests
- edit in test files of mapillary
@mahmoudadel54
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2 …
dc36c20 
…into feature_9978
@mahmoudadel54
geosolutions-it#9978: Add 360 photo support with Mapillary
d032ce5 
Description:
- edit in mapillary unit tests
allyoucanmap
allyoucanmap requested changes Mar 13, 2024
View reviewed changes
web/client/components/map/cesium/plugins/VectorLayer.js Outdated Show resolved Hide resolved
web/client/components/map/openlayers/Layer.jsx Outdated Show resolved Hide resolved
web/client/components/map/openlayers/plugins/VectorLayer.js Outdated Show resolved Hide resolved
web/client/configs/localConfig.json Outdated Show resolved Hide resolved
web/client/plugins/StreetView/StreetView.jsx Outdated Show resolved Hide resolved
web/client/plugins/StreetView/epics/streetView.js Outdated Show resolved Hide resolved
web/client/plugins/StreetView/epics/streetView.js Outdated Show resolved Hide resolved
web/client/plugins/StreetView/selectors/streetView.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
web/client/plugins/StreetView/components/MapillaryView/MapillaryView.jsx Outdated Show resolved Hide resolved
@mahmoudadel54
geosolutions-it#9978: Resolve review comments on [360 photo support w…
aa950c6 
…ith Mapillary]

Description:
-  remove all the changes in VectorLayer and move zoomTo layer in streetView epics
- add a notification if the service is not available for mapillary custom data layer
- replace legacy way of style with geostyler for marker streetview
- edit the streetview in monitorState to be more specific
- edit unit cases based on changes
@allyoucanmap allyoucanmap marked this pull request as ready for review April 9, 2024 14:14
@tdipisa tdipisa merged commit 0ec0d92 into geosolutions-it:master Apr 16, 2024
6 checks passed
@tdipisa
Copy link
Member

tdipisa commented Apr 16, 2024 •
edited
Loading

@ElenaGallo just merged this. Please test this in DEV asap once deployed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C040-COMUNE_GE-2023-CUSTOM-SUPPORT New Feature used for new functionalities new
4 participants
@mahmoudadel54 @tdipisa @offtherailz @allyoucanmap