Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve row merging #619

Merged
merged 4 commits into from
Aug 4, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint again
  • Loading branch information
igorbernstein2 committed Aug 4, 2022
commit a4debf46d5726963ed449b1a4efb109b9624f2f0
5 changes: 4 additions & 1 deletion tests/unit/test_row_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -1461,7 +1461,10 @@ def __init__(self, **kw):

def _ReadRowsResponseV2(chunks, last_scanned_row_key=b""):
from google.cloud.bigtable_v2.types import bigtable as messages_v2_pb2
return messages_v2_pb2.ReadRowsResponse(chunks=chunks, last_scanned_row_key=last_scanned_row_key)

return messages_v2_pb2.ReadRowsResponse(
chunks=chunks, last_scanned_row_key=last_scanned_row_key
)


def _generate_cell_chunks(chunk_text_pbs):
Expand Down
5 changes: 4 additions & 1 deletion tests/unit/test_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -2208,7 +2208,10 @@ def next(self):

def _ReadRowsResponseV2(chunks, last_scanned_row_key=b""):
from google.cloud.bigtable_v2.types import bigtable as messages_v2_pb2
return messages_v2_pb2.ReadRowsResponse(chunks=chunks, last_scanned_row_key=last_scanned_row_key)

return messages_v2_pb2.ReadRowsResponse(
chunks=chunks, last_scanned_row_key=last_scanned_row_key
)


def _TablePB(*args, **kw):
Expand Down