Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve row merging #619

Merged
merged 4 commits into from
Aug 4, 2022
Merged

perf: improve row merging #619

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5969da
fix: improve row merging perf by 10x
igorbernstein2 Aug 4, 2022
609cddd
fix tests
igorbernstein2 Aug 4, 2022
f310b6b
lint
igorbernstein2 Aug 4, 2022
a4debf4
lint again
igorbernstein2 Aug 4, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@igorbernstein2
igorbernstein2 committed Aug 4, 2022
commit f310b6be30a2bb6366918412cc9c7d7556437175
1 change: 1 addition & 0 deletions tests/unit/test_row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,6 +1463,7 @@ def _ReadRowsResponseV2(chunks, last_scanned_row_key=b""):
from google.cloud.bigtable_v2.types import bigtable as messages_v2_pb2
return messages_v2_pb2.ReadRowsResponse(chunks=chunks, last_scanned_row_key=last_scanned_row_key)


def _generate_cell_chunks(chunk_text_pbs):
from google.protobuf.text_format import Merge
from google.cloud.bigtable_v2.types.bigtable import ReadRowsResponse
Expand Down