Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimize row merging #628

Merged
merged 25 commits into from
Aug 17, 2022
Merged

perf: optimize row merging #628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e3bd84c
test: improve the row merging tests
igorbernstein2 Aug 5, 2022
32c0551
fix type annotation
igorbernstein2 Aug 5, 2022
0dcdec4
fix lints
igorbernstein2 Aug 5, 2022
a6345e0
fix coverage
igorbernstein2 Aug 5, 2022
36e29ca
fix pytest warning
igorbernstein2 Aug 5, 2022
5c89bc7
wip - new row merger
igorbernstein2 Aug 5, 2022
b33f5ad
wip: split into methods
igorbernstein2 Aug 8, 2022
894d3da
Merge remote-tracking branch 'origin/main' into row_merger
igorbernstein2 Aug 8, 2022
6465a9d
format
igorbernstein2 Aug 8, 2022
6b70004
tweaks
igorbernstein2 Aug 8, 2022
1fd7e46
lint
igorbernstein2 Aug 8, 2022
01f4680
fixes
igorbernstein2 Aug 8, 2022
a93efbc
improve coverage
igorbernstein2 Aug 10, 2022
a848082
lint
igorbernstein2 Aug 10, 2022
60f7fee
typo
igorbernstein2 Aug 10, 2022
1ca5745
comment
igorbernstein2 Aug 10, 2022
b73ec7d
coverage
igorbernstein2 Aug 10, 2022
71f4513
coverage
igorbernstein2 Aug 10, 2022
62a6c19
lint
igorbernstein2 Aug 10, 2022
2ca3e62
remove unecssary check
igorbernstein2 Aug 10, 2022
9db0027
Merge remote-tracking branch 'origin/main' into row_merger
igorbernstein2 Aug 17, 2022
ef8cf3f
Merge remote-tracking branch 'igor/row_merger' into row_merger
igorbernstein2 Aug 17, 2022
37d1ced
address feedback
igorbernstein2 Aug 17, 2022
9012af1
flake8
igorbernstein2 Aug 17, 2022
2b28101
revert accidental commit
igorbernstein2 Aug 17, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lints
  • Loading branch information
@igorbernstein2
igorbernstein2 committed Aug 5, 2022
commit 0dcdec40beed3857e54ac3797dfd24dc8a636796
2 changes: 0 additions & 2 deletions tests/unit/test_row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
# limitations under the License.


import os

import mock
import pytest

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_row_merger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import proto
import pytest

from google.cloud.bigtable.row_data import PartialRowsData, PartialRowData
from google.cloud.bigtable.row_data import PartialRowsData, PartialRowData, InvalidChunk
from google.cloud.bigtable_v2.types.bigtable import ReadRowsResponse


Expand Down Expand Up @@ -70,7 +70,7 @@ def fake_read(*args, **kwargs):
try:
for row in PartialRowsData(fake_read, request=None):
actual_results.extend(extract_results_from_row(row))
except:
except (InvalidChunk, ValueError):
actual_results.append(ReadRowsTest.Result(error=True))

for expected, actual in zip_longest(test_case.results, actual_results):
Expand Down