Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize row merging #628

Merged
merged 25 commits into from
Aug 17, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: improve the row merging tests
- extract read-rows-acceptance-test.json based tests into own file
- update the json to match the latest available in https://github.com/googleapis/conformance-tests/tree/main/bigtable/v2
- use parameterized pytest test to run all of the scenarios (instead of creating a function for each json blob)
- use json protobufs to parse the file

I left a TODO to allow easy updates of the file, unfortunately its not straight forward as the canonical protos get renamed for python gapic
Next PR will extract row merging functionality from row_data to make it easier to maintain
  • Loading branch information
igorbernstein2 committed Aug 5, 2022
commit e3bd84c1a171413244820141c0497818b5796e99
Loading