Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: find emulator project id from environment variable #843

Merged
merged 4 commits into from
Feb 16, 2024
Merged

feat: find emulator project id from environment variable #843

merged 4 commits into from
Feb 16, 2024

Commits on Feb 16, 2024

  1. feat: find emulator project id from environment variable 

    Previously, if `FIRESTORE_EMULATOR_HOST` was set and a `Client` instance was created without an explicit project, it would fall-back to `google-cloud-firestore-emulator`

This change makes it check the `GCLOUD_PROJECT` variable for a project id first, which is used by the firebase functions emulator. This means the client will auto-detect the project id if not given in the emulator, just like in a live GCP environment

Fixes firebase/firebase-functions-python#174
    @daniel-sanche
    daniel-sanche committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    eb454f1 View commit details
    Browse the repository at this point in the history

  2. added GOOGLE_CLOUD_PROJECT env var

    @daniel-sanche
    daniel-sanche committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    3413352 View commit details
    Browse the repository at this point in the history

  3. added test

    @daniel-sanche
    daniel-sanche committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    01bb84d View commit details
    Browse the repository at this point in the history

  4. removed unneeded import

    @daniel-sanche
    daniel-sanche committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b76d5de View commit details
    Browse the repository at this point in the history