Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find emulator project id from environment variable #843

Merged
merged 4 commits into from
Feb 16, 2024
Merged
Next Next commit
feat: find emulator project id from environment variable
Previously, if `FIRESTORE_EMULATOR_HOST` was set and a `Client` instance was created without an explicit project, it would fall-back to `google-cloud-firestore-emulator`

This change makes it check the `GCLOUD_PROJECT` variable for a project id first, which is used by the firebase functions emulator. This means the client will auto-detect the project id if not given in the emulator, just like in a live GCP environment

Fixes firebase/firebase-functions-python#174
  • Loading branch information
daniel-sanche committed Feb 16, 2024
commit eb454f13e9b187741622a8033f41372b36aabe32
3 changes: 2 additions & 1 deletion google/cloud/firestore_v1/base_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def __init__(
if credentials is None:
credentials = AnonymousCredentials()
if project is None:
project = _DEFAULT_EMULATOR_PROJECT
# extract project from env var, or use system default
project = os.getenv("GCLOUD_PROJECT", _DEFAULT_EMULATOR_PROJECT)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add GOOGLE_CLOUD_PROJECT here


super(BaseClient, self).__init__(
project=project,
Expand Down
Loading