Skip to content

Commit

Permalink
Tabs: Remove presentation role
Browse files Browse the repository at this point in the history
Fixes #10122
Closes gh-1748
  • Loading branch information
milk54 authored and scottgonzalez committed Sep 29, 2016
1 parent c481400 commit b9ffc34
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions tests/unit/tabs/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ QUnit.test( "aria-controls", function( assert ) {
} );

QUnit.test( "accessibility", function( assert ) {
assert.expect( 49 );
assert.expect( 46 );
var element = $( "#tabs1" ).tabs( {
active: 1,
disabled: [ 2 ]
Expand All @@ -118,7 +118,6 @@ QUnit.test( "accessibility", function( assert ) {
panel = panels.eq( index );
assert.equal( tab.attr( "role" ), "tab", "tab " + index + " role" );
assert.equal( tab.attr( "aria-labelledby" ), anchorId, "tab " + index + " aria-labelledby" );
assert.equal( anchor.attr( "role" ), "presentation", "anchor " + index + " role" );
assert.equal( anchor.attr( "tabindex" ), -1, "anchor " + index + " tabindex" );
assert.equal( panel.attr( "role" ), "tabpanel", "panel " + index + " role" );
assert.equal( panel.attr( "aria-labelledby" ), anchorId, "panel " + index + " aria-labelledby" );
Expand Down
1 change: 0 additions & 1 deletion ui/widgets/tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,6 @@ $.widget( "ui.tabs", {
return $( "a", this )[ 0 ];
} )
.attr( {
role: "presentation",
tabIndex: -1
} );
this._addClass( this.anchors, "ui-tabs-anchor" );
Expand Down

0 comments on commit b9ffc34

Please sign in to comment.