Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove role:"presentation" in tabs.js. #1748

Closed
wants to merge 1 commit into from
Closed

Conversation

milk54
Copy link
Contributor

@milk54 milk54 commented Sep 18, 2016

According to the ARIA in HTML (https://www.w3.org/TR/html-aria/), The a element with a href can to use ARIA roles is button, checkbox, menuitem, menuitemcheckbox, menuitemradio, radio, tab, switch or treeitem.
So, The a element can't to use role="presentation". (invalid)
Because, It has been reported in bug by jQuery UI, but It has been laid aside for two year.
https://bugs.jqueryui.com/ticket/10122

Please merge this pull request.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@jzaefferer
Copy link
Member

Spec compliance is nice, but not our primary goal. Foremost, it needs to work for our users. That said, have you tested this (before and after) in a screenreader? See http://wiki.jqueryui.com/w/page/43766322/Accessibility-Overview for details on what screenreaders we (try to) support.

@milk54
Copy link
Contributor Author

milk54 commented Sep 24, 2016

Thank you for description. I think so, too..

I Knew it. Because, I had do test 4 type screen readers(PC-Talker7+IE11,NVDA2016.3jp+Firefox48.0.2,iOS9.3.5 ViceOver,Andoroid5.0.1 TalkBack5.0.4) too.
Of course, For both if a element has role="presentation" is not the case was the same result.(no problem)
If the same result, I think better a element don't has role="presentation" rather than element has role="presentation".

What are your thoughts on that?

@scottgonzalez
Copy link
Member

Perhaps screen readers have changed how they handle this in the past four years. If you're not finding any differences with or without the role, it sounds like it's safe to remove it.

@colinbdclark @hanshillen Do you see any problems with this?

@colinbdclark
Copy link

colinbdclark commented Sep 28, 2016

I asked a few of the ARIA and accessibility experts at the IDRC, and here is a summary of their responses:

"I would actually suspect that most AT would disregard role="presentation" in this case, much like VoiceOver ignores empty alt text when it’s used on images serving as links, since it’s impossible for links to be decorative. So based on what I could gather I’d say remove it, but maybe I’m missing some context."

@klown said: "There is a new section in the ARIA 1.1 draft spec that describes cases where applying role="presentation" has no effect; indeed, where user agents are required to ignore the role and use the native semantic. I think this case is one of those."

I hope this helps!

@klown
Copy link

klown commented Sep 28, 2016

@colinbdclark wrote:

@klown said: "There is a new section in the ARIA 1.1 draft spec that describes cases where applying role="presentation" has no effect; indeed, where user agents are required to ignore the role and use the native semantic. I think this case is one of those."

Here is a link:
Presentational Role Conflict Resolution

@scottgonzalez
Copy link
Member

Thanks. In the future, please make sure to run the tests as this caused failures. I updated the tests before merging.

@milk54
Copy link
Contributor Author

milk54 commented Sep 30, 2016

Thank you. I'm sorry if I had a misconception, I ran the test the latest [updated] data by Travis CI.(commit b9ffc34)

Test results was without errors.

build:passed

Please let me know the details, if I have to do other tests.

@milk54
Copy link
Contributor Author

milk54 commented Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants