effects.blind: fix: save the wrapper status if already wrapped. #6245 #320
Conversation
… - position: absolute is lost when .stop() is used with .show('blind').
| @@ -31,7 +31,11 @@ $.effects.effect.blind = function( o ) { | |||
| animation = {}, | |||
| wrapper, distance; | |||
|
|
|||
| $.effects.save( el, props ); | |||
| // if already wrapped, the wrapper's properties are my property. #6245 | |||
| if ( el.parent().is( ".ui-effects-wrapper" ) ) | |||
There was a problem hiding this comment.
You should use brackets for an if statement.
…x: #6245 - position: absolute is lost when .stop() is used with .show('blind').
|
Sorry. I added {}, and rewrite the commit comment. |
|
Once again I ask - does this problem also affect other effects? If so, maybe there is a better solution inside |
|
As I wrote in the pull request message, this problem is because blind is the only effect which animates the wrapper. Now, there is no effect which uses the wrapper. But there could be in the future. In such case, which is better, modify the core or just fix blind effect? |
|
Hrm... Alright, if this is the only one for now, lets leave the solution to the problem here... I think this one ready to pull with a squash @scottgonzalez |
|
Thanks, landed in 129d5c7. |
effects.blind: fix: save the wrapper status if already wrapped. #6245 - position: absolute is lost when .stop() is used with .show('blind').
Overriding the stack with position:absolute, top/left: 0 made the problem.
This new function saves its owner position info instead of the parameters of itself.
This problem is maybe unique to blind, because blind is the only effect which animates the wrapper.
The test file is here.
https://gist.github.com/982853