Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

effects.blind: fix: save the wrapper status if already wrapped. #6245 #320

Closed
wants to merge 2 commits into from
Closed

effects.blind: fix: save the wrapper status if already wrapped. #6245 #320

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1439013
effects.blind: fix: save the wrapper status if already wrapped. #6245…
tomykaira May 20, 2011
1b95896
effects.blind: save the wrapper status if already wrapped.(add {}) Fi…
tomykaira May 22, 2011
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
effects.blind: fix: save the wrapper status if already wrapped. #6245… 
… - position: absolute is lost when .stop() is used with .show('blind').
  • Loading branch information
@tomykaira
tomykaira committed May 20, 2011
commit 1439013335a021a9951cd71057a8724847f1f1fd
6 changes: 5 additions & 1 deletion ui/jquery.effects.blind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ $.effects.effect.blind = function( o ) {
animation = {},
wrapper, distance;

$.effects.save( el, props );
// if already wrapped, the wrapper's properties are my property. #6245
if ( el.parent().is( ".ui-effects-wrapper" ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use brackets for an if statement.
$.effects.save( el.parent(), props );
else
$.effects.save( el, props );
el.show();
wrapper = $.effects.createWrapper( el ).css({
overflow: "hidden"
Expand Down