doc: remove the last <pre> tag #53741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
|
Fast-track has been requested by @ovflowd. Please 👍 to approve. |
RedYetiDev
reviewed
Jul 6, 2024
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
anonrig
approved these changes
Jul 6, 2024
lpinca
approved these changes
Jul 6, 2024
UlisesGascon
approved these changes
Jul 6, 2024
marco-ippolito
approved these changes
Jul 6, 2024
ovflowd
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53741 ✔ Done loading data for nodejs/node/pull/53741 ----------------------------------- PR info ------------------------------------ Title doc: remove the lasttag (#53741) Author Claudio W (@ovflowd) Branch ovflowd:doc-remove-pre-tag -> nodejs:main Labels doc, fast-track, commit-queue-squash Commits 2 - doc: remove the lasttag - Update doc/api/modules.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/53741 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: Ulises Gascón Reviewed-By: Marco Ippolito ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53741 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: Ulises Gascón Reviewed-By: Marco Ippolito -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 06 Jul 2024 00:15:46 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53741#pullrequestreview-2161354259 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53741#pullrequestreview-2161445675 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53741#pullrequestreview-2161501096 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53741#pullrequestreview-2161504423 ℹ This PR is being fast-tracked ✘ This PR needs to wait 37 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9818600432 |
|
Can someone else approve the fast track? 👀 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ea71187 |
RedYetiDev
added
the
author ready
|
(Post-Mortem label fix - author ready w/ commit-queue, right?) |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
PR-URL: #53741 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53741 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last
<pre>tag from the API docs, which is needed in preparation for the new API Doc Tooling