meta: use HTML entities in commit-queue comment
#53744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
lpinca
approved these changes
Jul 6, 2024
aduh95
approved these changes
Jul 6, 2024
aduh95
added
author ready
ExE-Boss
reviewed
Jul 7, 2024
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
jasnell
approved these changes
Jul 7, 2024
aduh95
added
the
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 53483a1 |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
PR-URL: #53744 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53744 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the comments for
commit-queue-failed, parts wrapped in<and>aren't rendered, as they are treated as HTML.An example of this is emails, and some weird rendering for #53741 (comment), which contains
<pre>in the title.This PR replaces those items with HTML entities, allowing them to properly render.