Gizmo fixes #6763
Merged
Gizmo fixes #6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ const SHADER = { | |||
| // store z/w for later use in fragment shader | |||
| vZW = gl_Position.zw; | |||
| // disable depth clipping | |||
| gl_Position.z = 0.0; | |||
| // gl_Position.z = 0.0; | |||
There was a problem hiding this comment.
It looks cleaner when clipping with this so would prefer to have it in but the selection area and rendered area do not align
| @@ -122,7 +122,8 @@ data.set('camera', { | |||
| }); | |||
| const camera = new pc.Entity('camera'); | |||
| camera.addComponent('camera', { | |||
| clearColor: new pc.Color(0.1, 0.1, 0.1) | |||
| clearColor: new pc.Color(0.1, 0.1, 0.1), | |||
| farClip: 1000 | |||
There was a problem hiding this comment.
Why won't the example work with the default far clip?
There was a problem hiding this comment.
It does it you can just see the the axis lines clipping when zooming out
| @@ -264,28 +265,40 @@ class RotateGizmo extends TransformGizmo { | |||
| return this._shapes.x.tolerance; | |||
| } | |||
|
|
|||
| /** | |||
| * @param {string} prop - The property. | |||
| * @param {any} value - The value. | |||
There was a problem hiding this comment.
Isn't the type here number?
| @@ -315,40 +315,67 @@ class ScaleGizmo extends TransformGizmo { | |||
| return this._shapes.xyz.tolerance; | |||
| } | |||
|
|
|||
| /** | |||
| * @param {string} prop - The property name. | |||
| * @param {any} value - The property value. | |||
| _setArrowProp(prop, value) { | ||
| this._shapes.x[prop] = value; | ||
| this._shapes.y[prop] = value; | ||
| this._shapes.z[prop] = value; | ||
| } | ||
|
|
||
| /** | ||
| * @param {string} prop - The property name. | ||
| * @param {any} value - The property value. |
| _colorSemi(color) { | ||
| const clone = color.clone(); | ||
| clone.a = this._colorAlpha; | ||
| return clone; | ||
| } | ||
|
|
||
| /** | ||
| * @param {string} axis - The axis to update. | ||
| * @param {any} value - The value to set. |
| @@ -305,18 +311,31 @@ class TranslateGizmo extends TransformGizmo { | |||
| return this._shapes.face.tolerance; | |||
| } | |||
|
|
|||
| /** | |||
| * @param {string} prop - The property to set. | |||
| * @param {any} value - The value to set. | |||
There was a problem hiding this comment.
OK, I'm gonna stop pointing these out now....maybe there's a good reason it's any! 😄
There was a problem hiding this comment.
All of these are any because its a generic property update so the property could technically be any type
willeastcott
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6671
Fixes #6695