Remove no-longer-used MTRDevice logic for truncating data version lists #34183
+60
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After project-chip#34111, ReadClient handles this logic itself, so the attempted truncation in MTRDevice was now dead code.
|
PR #34183: Size comparison from ee0d96e to 493c5f8 Full report (27 builds for bl602, bl702, bl702l, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
jtung-apple
approved these changes
Jul 3, 2024
jtung-apple
reviewed
Jul 3, 2024
|
PR #34183: Size comparison from ee0d96e to aa4097a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -403,6 +403,7 @@ CHIP_ERROR ReadClient::BuildDataVersionFilterList(DataVersionFilterIBs::Builder | |||
| const Span<DataVersionFilter> & aDataVersionFilters, | |||
| bool & aEncodedDataVersionList) | |||
| { | |||
| ChipLogProgress(DataManagement, "Attempting to encode %lu data version filters", static_cast<unsigned long>(aDataVersionFilters.size())); | |||
There was a problem hiding this comment.
We could move this to the end so in either case we get one log statement saying how many we encoded
There was a problem hiding this comment.
The "we didn't encode everything" log statement logs how many were chopped off. Not that this is not trivially derivable from "how many we encoded" and "how many we were asked to encode", since we skip encoding the ones that don't match our request paths.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #34111, ReadClient handles this logic itself, so the attempted truncation in MTRDevice was now dead code.
REVIEW NOTE: A whitespace-ignoring diff might be simpler to review.