[all] Replace the complex canCreate with deductionRule #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function are implementing commonly found deduction strategies used in SOFA.
Currently object factory use the canCreate function for several purpose, one of them is to deduce the template depending on the scene graph context. The new implementation allows to do the same without the need of the canCreate "static overrides"
…teDeductionMethod This method is used to implement a template deduction mechanisme for a whole hierarchy of classes instead of having heave class setting its own during the registration in the factory. Eg: all CollisionModel implements the same TemplateDeductionMethod
If there is not provided template, then the collision model will be created with the template returned by using the getTemplateFromMechanical().
… it is not needed anymore)
…teDeductionMethod This method is used to implement a template deduction mechanisme for a whole hierarchy of classes instead of having heave class setting its own during the registration in the factory. Eg: all CollisionModel implements the same TemplateDeductionMethod
If there is not provided template, then the collision model will be created with the template returned by using the getTemplateFromMechanical().
… it is not needed anymore)
…pr-refactor-cancreate-v2
…ver it is appropriate
|
[ci-build][with-scene-tests][with-regression-tests] |
|
[ci-build][with-scene-tests][with-regression-tests] |
…pr-replace-can-create-with-deductionrule # Conflicts: # Sofa/Component/LinearSolver/Preconditioner/src/sofa/component/linearsolver/preconditioner/PrecomputedWarpPreconditioner.inl
…ctionrule' into pr-replace-can-create-with-deductionrule-step2
…ctionrule-step2' into pr-replace-can-create-with-deductionrule-step3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up #3990 but now we focus on the complex use cases of canCreate.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if