Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topology.Container.Dynamic] Add class TriangleSubdividers to store methods to subdivide a triangle in differents configurations #4747

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

epernod
Copy link
Contributor

@epernod epernod commented May 20, 2024

Add utility class for TriangleSetTopologyModifier component.
The class TriangleSubdivider is derived in 5 specializations to reflect the 5 possible scenario to subdivide a triangle.

Those subdividers will be used in the new version of Triangle incision in TriangleSetGeometryAlgorithms

Todo, finish the tests:

  • testSubdivider_1Node();
  • testSubdivider_1Edge();
  • testSubdivider_2Edge();
  • testSubdivider_3Edge();
  • testSubdivider_2Node();

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).
@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels May 20, 2024
@epernod
Copy link
Contributor Author

epernod commented May 21, 2024

[ci-build][with-all-tests]

@epernod epernod marked this pull request as draft May 21, 2024 06:59
@epernod epernod added this to the v24.12 milestone May 22, 2024
@fredroy fredroy added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Implement a new feature pr: status wip Development in the pull-request is still in progress
2 participants