Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lagrangian.Model] Use base class Data instead of protected class member for constraint id #4763

Merged
merged 8 commits into from
Jul 17, 2024
Merged

[Lagrangian.Model] Use base class Data instead of protected class member for constraint id #4763

merged 8 commits into from
Jul 17, 2024

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Jun 4, 2024 •
edited
Loading

related to SofaDefrost/SoftRobots#283

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 4, 2024
@alxbilger alxbilger mentioned this pull request Jun 4, 2024
Merged
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]
@alxbilger alxbilger force-pushed the constraintid branch 2 times, most recently from be533c8 to a1472e4 Compare June 5, 2024 14:17
@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jun 19, 2024
@alxbilger alxbilger mentioned this pull request Jun 24, 2024
Merged
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jul 11, 2024
@alxbilger alxbilger marked this pull request as ready for review July 11, 2024 09:04
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 17, 2024
@hugtalbot hugtalbot merged commit 9e85831 into sofa-framework:master Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
4 participants
@alxbilger @EulalieCoevoet @bakpaul @hugtalbot