Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Clean some warnings #4805

Merged
merged 3 commits into from
Jul 17, 2024
Merged

[all] Clean some warnings #4805

merged 3 commits into from
Jul 17, 2024

Conversation

hugtalbot
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jul 2, 2024
@hugtalbot hugtalbot added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jul 2, 2024
@fredroy
Copy link
Contributor

fredroy commented Jul 2, 2024

[ci-build][with-all-tests]
@fredroy fredroy force-pushed the 202407_clean_some_warnings branch from 3106e0e to 2e4f095 Compare July 3, 2024 00:19
alxbilger
alxbilger requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready for me
applications/projects/SofaPhysicsAPI/src/SofaPhysicsAPI/SofaPhysicsSimulation.cpp Outdated Show resolved Hide resolved
@hugtalbot hugtalbot requested a review from alxbilger July 15, 2024 14:59
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 17, 2024
@hugtalbot hugtalbot merged commit c35d86d into sofa-framework:master Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
4 participants
@hugtalbot @fredroy @alxbilger @bakpaul