-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Remove SOFA_ENABLE_LEGACY_HEADERS usage #4813
base: master
Are you sure you want to change the base?
[All] Remove SOFA_ENABLE_LEGACY_HEADERS usage #4813
Conversation
[ci-build][with-all-tests] |
7365d3d
to
d7398bd
Compare
[ci-build][with-all-tests] |
e95ef09
to
b3d6f23
Compare
…module SofaExporter
b3d6f23
to
f25b6e9
Compare
|
…eVisitor and DefaultCollisionManager
So I took a look at the SleepController. It simply puts context to sleep where the mechanical object has a max velocity under a certain threshold. Then wake them up again only when a collision occurs with another object that is moving.
Sincerely, I cannot see myself advising anyone to use it in their scene given the fact that the use case doesn't apply for the majority of the scenes (especially for soft robotics). So I wouldn't mind never seeing it again... |
A continuation of
but much bigger and less trivial.
This PR removes SOFA_ENABLE_LEGACY_HEADERS, implying:
The deletion of the layer compat between old and new modules was acted for 23.06 so not a big deal by itself (only 1.5 year late🤷♂️ ).
But some olden modules still have some code/components:
Gravity
componentDefaultCollisionGroupManager, SolverMerger
components andRayTriangleVisitor
visitorSleepController
componentThere is also SofaExporter which had some forgotten(?) examples of components which were moved. So the examples have been just moved as well
So what should be done for these components?
IMO (not done yet)
Gravity
seems useless/not usable.SleepController
might maybe probably be interestingDefaultCollisionGroupManager, SolverMerger
were bogus and RayTriangleVisitor not used at allapplications/plugins
)To be discussed.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if