Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap script shouldn't do a git pull, should instead warn about existing checkout #238

Closed
mithro opened this issue Mar 28, 2016 · 0 comments

Comments

@mithro
Copy link
Member

mithro commented Mar 28, 2016

Currently the bootstrap script does;

if [ -e HDMI2USB-misoc-firmware ]; then
 cd HDMI2USB-misoc-firmware
 git pull || exit 1
else
 git clone --recurse-submodules $GIT_REPO || exit 1
 cd HDMI2USB-misoc-firmware
 git checkout $GIT_BRANCH || exit 1
fi

It should do;

if [ -e HDMI2USB-misoc-firmware ]; then
  echo "Existing checkout found (see HDMI2USB-misoc-firmware directory), please remove before running."
  exit 1
else
 git clone --recurse-submodules $GIT_REPO || exit 1
 cd HDMI2USB-misoc-firmware
 git checkout $GIT_BRANCH || exit 1
fi
Vikram9866 added a commit to Vikram9866/HDMI2USB-misoc-firmware that referenced this issue Apr 6, 2016
mithro added a commit that referenced this issue Apr 11, 2016
 * Fixes #238 - "Bootstrap script shouldn't do a `git pull`, should instead warn about existing checkout."
 * Fixes #239 - "Bootstrap and other scripts should refuse to run as root."
mithro added a commit that referenced this issue Jan 30, 2020
Add NeTV2 support and HDMI2PCIe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment