-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 4.2 non-normative #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % language nits, as you don't want to use "should" in non-normative sections.
index.html
Outdated
<a>PerformanceResourceTiming</a> objects in the [=request/client=]'s | ||
[=environment settings object/global object=]'s <a data-cite= | ||
"PERFORMANCE-TIMELINE-2#performance-timeline">Performance | ||
Timeline</a>, unless excluded from the timeline as part of the | ||
[=fetch|fetching process=]. Resources that are retrieved from | ||
<a data-cite="HTML#relevant-application-cache">relevant application | ||
caches</a> or local resources MUST be included as | ||
caches</a> or local resources should also be included as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/should also be/are/?
index.html
Outdated
<a>PerformanceResourceTiming</a> objects in the <a data-cite= | ||
"PERFORMANCE-TIMELINE-2#performance-timeline">Performance | ||
Timeline</a> [[PERFORMANCE-TIMELINE-2]]. Resources for which the | ||
[=fetch=] was initiated, but was later aborted (e.g. due to a network | ||
error) MAY be included as <a>PerformanceResourceTiming</a> objects in | ||
error) should be included as <a>PerformanceResourceTiming</a> objects in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/should be/are/
370a616
to
3ecbdaf
Compare
Closes #256
Preview | Diff