-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetcaster] Merge jetcaster/all_form_factors
into main
#1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shared `core` module containing: * Database-related classes * Networking classes * Repositories Also added `designsystem` module containing color and typography primitives. Added M3 themes and colors currently unused but will start migrating Jetcaster to M3 in subsequent PRs.
Upgrading Jetcaster from M2 to M3. This migration changes one of the original purposes of the sample which was to demonstrate dynamic theming. We would still like to demonstrate dynamic theming but using a more modern approach using Material's [material-color-utilities](https://github.com/material-foundation/material-color-utilities). ![Screenshot_20240319_131815](https://github.com/android/compose-samples/assets/463186/45b8cf0e-6899-437c-87db-891dcb47a8eb)
This PR adds a module for TV app.
…over/Discover.kt Co-authored-by: Tomáš Mlynarič <mlykotom@google.com>
Adds a screen for the list of episodes for a Podcast
- Add loading and empty state for Player - Adds queue button to the screen and view model
Changes: * Added tests for `MockEpisodePlayer` * Update styling to match design in `PlayerScreen` * Supporting adding to queue from `PlayerScreen`
arriolac
requested review from
riggaroo,
compose-devrel-github-bot,
bentrengrove,
chikoski,
kul3r4 and
jdkoren
and removed request for
riggaroo
April 15, 2024 16:31
kul3r4
approved these changes
Apr 15, 2024
jdkoren
approved these changes
Apr 15, 2024
Adds the queue screen and some refactoring
chikoski
approved these changes
Apr 15, 2024
bentrengrove
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Jetcaster sample now demonstrates how to build an app with Compose such that it supports the following form factors: phones, tablets, foldables, TV and Wear.