feat: find emulator project id from environment variable #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if `FIRESTORE_EMULATOR_HOST` was set and a `Client` instance was created without an explicit project, it would fall-back to `google-cloud-firestore-emulator` This change makes it check the `GCLOUD_PROJECT` variable for a project id first, which is used by the firebase functions emulator. This means the client will auto-detect the project id if not given in the emulator, just like in a live GCP environment Fixes firebase/firebase-functions-python#174
product-auto-label
bot
added
size: xs
lahirumaramba
approved these changes
Feb 16, 2024
| @@ -131,7 +131,8 @@ def __init__( | |||
| if credentials is None: | |||
| credentials = AnonymousCredentials() | |||
| if project is None: | |||
| project = _DEFAULT_EMULATOR_PROJECT | |||
| # extract project from env var, or use system default | |||
| project = os.getenv("GCLOUD_PROJECT", _DEFAULT_EMULATOR_PROJECT) | |||
There was a problem hiding this comment.
I think we should also add GOOGLE_CLOUD_PROJECT here
product-auto-label
bot
added
size: s
gkevinzheng
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
FIRESTORE_EMULATOR_HOSTwas set and aClientinstance was created without an explicit project, it would fall-back togoogle-cloud-firestore-emulatorThis change makes it check the
GCLOUD_PROJECTvariable for a project id first, which is used by the firebase functions emulator. This means the client will auto-detect the project id if not given in the emulator, just like in a live GCP environmentFixes firebase/firebase-functions-python#174
BEGIN_COMMIT_OVERRIDE
fix: find emulator project id from environment variable
END_COMMIT_OVERRIDE