Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: find emulator project id from environment variable #843

Merged
merged 4 commits into from
Feb 16, 2024
Merged

feat: find emulator project id from environment variable #843

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb454f1
feat: find emulator project id from environment variable
daniel-sanche Feb 16, 2024
3413352
added GOOGLE_CLOUD_PROJECT env var
daniel-sanche Feb 16, 2024
01bb84d
added test
daniel-sanche Feb 16, 2024
b76d5de
removed unneeded import
daniel-sanche Feb 16, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion google/cloud/firestore_v1/base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def __init__(
if credentials is None:
credentials = AnonymousCredentials()
if project is None:
project = _DEFAULT_EMULATOR_PROJECT
# extract project from env var, or use system default
project = os.getenv("GCLOUD_PROJECT", _DEFAULT_EMULATOR_PROJECT)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add GOOGLE_CLOUD_PROJECT here

super(BaseClient, self).__init__(
project=project,
Expand Down
Loading