Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use PingAndWarm request for channel priming #1179

Merged
merged 7 commits into from
Jul 19, 2022
Merged

feat: use PingAndWarm request for channel priming #1179

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16d97c1
feat: use PingAndWarm request for channel priming
mutianf Feb 18, 2022
5e7ebc7
update javadoc
mutianf Feb 22, 2022
dd63d68
add instance name to resource header
mutianf Mar 4, 2022
222d18b
add request deadline for ping and warm
mutianf Jun 16, 2022
411646e
add some comments
mutianf Jun 17, 2022
1b04745
adding todo
mutianf Jun 17, 2022
cbeb721
format
mutianf Jun 17, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add some comments
  • Loading branch information
@mutianf
mutianf committed Jul 19, 2022
commit 411646e95820859fcfa801ab95d34032baf4de15
5 changes: 3 additions & 2 deletions ...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ public class EnhancedBigtableStubSettings extends StubSettings<EnhancedBigtableS
private static final Set<Code> IDEMPOTENT_RETRY_CODES =
ImmutableSet.of(Code.DEADLINE_EXCEEDED, Code.UNAVAILABLE);

private static Duration PRIME_REQUEST_TIMEOUT = Duration.ofSeconds(30);

// Copy of default retrying settings in the yaml
private static final RetrySettings IDEMPOTENT_RETRY_SETTINGS =
RetrySettings.newBuilder()
Expand All @@ -116,6 +114,9 @@ public class EnhancedBigtableStubSettings extends StubSettings<EnhancedBigtableS
private static final Set<Code> READ_ROWS_RETRY_CODES =
ImmutableSet.<Code>builder().addAll(IDEMPOTENT_RETRY_CODES).add(Code.ABORTED).build();

// Priming request should have a shorter timeout
private static Duration PRIME_REQUEST_TIMEOUT = Duration.ofSeconds(30);

private static final RetrySettings READ_ROWS_RETRY_SETTINGS =
RetrySettings.newBuilder()
.setInitialRetryDelay(Duration.ofMillis(10))
Expand Down