Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use PingAndWarm request for channel priming #1179

Merged
merged 7 commits into from
Jul 19, 2022
Merged

feat: use PingAndWarm request for channel priming #1179

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16d97c1
feat: use PingAndWarm request for channel priming
mutianf Feb 18, 2022
5e7ebc7
update javadoc
mutianf Feb 22, 2022
dd63d68
add instance name to resource header
mutianf Mar 4, 2022
222d18b
add request deadline for ping and warm
mutianf Jun 16, 2022
411646e
add some comments
mutianf Jun 17, 2022
1b04745
adding todo
mutianf Jun 17, 2022
cbeb721
format
mutianf Jun 17, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format
  • Loading branch information
@mutianf
mutianf committed Jul 19, 2022
commit cbeb721c1b6d30c9b3a837a33f5287b9bcaa8ed5
3 changes: 2 additions & 1 deletion ...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ private void sendPrimeRequests(ManagedChannel managedChannel) throws IOException
try {
stub.pingAndWarmCallable().call(request);
igorbernstein2 marked this conversation as resolved.
Show resolved Hide resolved
} catch (Throwable e) {
mutianf marked this conversation as resolved.
Show resolved Hide resolved
// TODO: Not sure if we should swallow the error here. We are pre-emptively swapping channels if the new
// TODO: Not sure if we should swallow the error here. We are pre-emptively swapping
// channels if the new
// channel is bad.
if (e instanceof ExecutionException) {
e = e.getCause();
Expand Down