Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use PingAndWarm request for channel priming #1179

Merged
merged 7 commits into from
Jul 19, 2022
Merged

feat: use PingAndWarm request for channel priming #1179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16d97c1
feat: use PingAndWarm request for channel priming
mutianf Feb 18, 2022
5e7ebc7
update javadoc
mutianf Feb 22, 2022
dd63d68
add instance name to resource header
mutianf Mar 4, 2022
222d18b
add request deadline for ping and warm
mutianf Jun 16, 2022
411646e
add some comments
mutianf Jun 17, 2022
1b04745
adding todo
mutianf Jun 17, 2022
cbeb721
format
mutianf Jun 17, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update javadoc
  • Loading branch information
@mutianf
mutianf committed Jul 19, 2022
commit 5e7ebc75438153544d137c610f1c5274b5bc7f7e
6 changes: 0 additions & 6 deletions ...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,6 @@ public boolean isRefreshingChannel() {
}

/**
* Gets the table ids that will be used to send warmup requests when {@link
* #isRefreshingChannel()} is enabled.
*
* @deprecated This field is ignored. If {@link #isRefreshingChannel()} is enabled, warm up
* requests will be sent to all table ids of the instance.
*/
Expand Down Expand Up @@ -390,9 +387,6 @@ public Builder setPrimingTableIds(String... tableIds) {
}

/**
* Gets the table ids that will be used to send warmup requests when {@link
* #setRefreshingChannel(boolean)} is enabled.
*
* @deprecated This field is ignored. If {@link #isRefreshingChannel()} is enabled, warm up
* requests will be sent to all table ids of the instance.
*/
Expand Down
21 changes: 12 additions & 9 deletions ...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,11 @@ public boolean isRefreshingChannel() {
return isRefreshingChannel;
}

/** Gets the tables that will be primed during a channel refresh. */
@BetaApi("Channel priming is not currently stable and might change in the future")
/**
* @deprecated This field is ignored. If {@link #isRefreshingChannel()} is enabled, warm up
* requests will be sent to all table ids of the instance.
*/
@Deprecated
public List<String> getPrimedTableIds() {
return primedTableIds;
}
Expand Down Expand Up @@ -727,9 +730,8 @@ public String getAppProfileId() {
/**
* Sets if channels will gracefully refresh connections to Cloud Bigtable service.
*
* <p>When enabled, this will wait for the connection to complete the SSL handshake. The effect
* can be enhanced by configuring table ids that can be used warm serverside caches using {@link
* #setPrimedTableIds(String...)}.
* <p>When enabled, this will wait for the connection to complete the SSL handshake and warm up
* serverside caches for all the tables of the instance.
*
* @see com.google.cloud.bigtable.data.v2.BigtableDataSettings.Builder#setRefreshingChannel
*/
Expand All @@ -739,8 +741,11 @@ public Builder setRefreshingChannel(boolean isRefreshingChannel) {
return this;
}

/** Configures which tables will be primed when a connection is created. */
@BetaApi("Channel priming is not currently stable and might change in the future")
/**
* @deprecated This field is ignored. If {@link #isRefreshingChannel()} is enabled, warm up
* requests will be sent to all table ids of the instance.
*/
@Deprecated
public Builder setPrimedTableIds(String... tableIds) {
this.primedTableIds = ImmutableList.copyOf(tableIds);
return this;
Expand All @@ -753,8 +758,6 @@ public boolean isRefreshingChannel() {
}

/**
* Gets the tables that will be primed during a channel refresh.
*
* @deprecated This field is ignored. If {@link #isRefreshingChannel()} is enabled, warm up
* requests will be sent to all table ids of the instance.
*/
Expand Down